Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify meaning of ellipsis in bazel command #43890

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@willydee
Copy link
Contributor

@willydee willydee commented Oct 19, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #43888

What is the new behavior?

Note added explaining the relevance of ellipsis for Bazel commands

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@pullapprove pullapprove bot requested a review from devversion Oct 19, 2021
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Awesome!!! Great start. Thanks!

Reviewed-for: global-docs-approvers

Loading

@ngbot ngbot bot added this to the Backlog milestone Oct 19, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 19, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 19, 2021
Copy link
Member

@josephperrott josephperrott left a comment

LGTM to me overall, just one small change.

Loading

docs/DEVELOPER.md Outdated Show resolved Hide resolved
Loading
@google-cla
Copy link

@google-cla google-cla bot commented Oct 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Loading

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 19, 2021
@ngbot
Copy link

@ngbot ngbot bot commented Oct 20, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing
    pending status "ci/circleci: legacy-unit-tests-saucelabs" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Loading

@petebacondarwin petebacondarwin dismissed josephperrott’s stale review Oct 20, 2021

The requested changes were made.

@jessicajaniuk
Copy link
Contributor

@jessicajaniuk jessicajaniuk commented Oct 20, 2021

This PR was merged into the repository by commit b8f1f82.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment