Several elements fixes and improvements #43975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfaproject
reviewed
Oct 28, 2021
josephperrott
approved these changes
Oct 28, 2021
LGTM
| context.logger.info('Added "document-register-element" to polyfills.'); | ||
| }; | ||
| } | ||
| export default noop; |
There was a problem hiding this comment.
Does it make sense to have this schematic at least output that its a noop and no longer necessary to run?
There was a problem hiding this comment.
That’s a good idea.
There was a problem hiding this comment.
Thinking about it, maybe it's better to just drop the schematic and update the doc to use npm install @angular/elements --save
alan-agius4
changed the title
gkalpak
approved these changes
Oct 29, 2021
Thx, @alan-agius4
Commit message typos:
the browsers that Angular supports supports-->the browsers that Angular supports support(in a couple of commits)@@ungap/custom-element-->@ungap/custom-elements
All the [browsers](https://angular.io/guide/browser-support) that Angular supports `CustomElementRegistry` APIs
This section was outdated since now all CLI projects are es2015+ and don't require the polyfill since legacy browsers are no longer supported.
This schematic is no longer needed since all the [browsers](https://angular.io/guide/browser-support) that Angular supports `CustomElementRegistry` APIs. Side note: `document-register-element` has been deprecated in favor of `@ungap/custom-element`
…ndency The elements package doesn't use `@angular/platform-browser` therefore this is not needed.
This test has been removed as since the elements schematic has been removed in a previous commit.
|
This PR was merged into the repository by commit 6247efa. |
alxhub
added a commit
that referenced
this issue
Oct 29, 2021
All the [browsers](https://angular.io/guide/browser-support) that Angular supports `CustomElementRegistry` APIs PR Close #43975
alxhub
added a commit
that referenced
this issue
Oct 29, 2021
This section was outdated since now all CLI projects are es2015+ and don't require the polyfill since legacy browsers are no longer supported. PR Close #43975
alxhub
added a commit
that referenced
this issue
Oct 29, 2021
This schematic is no longer needed since all the [browsers](https://angular.io/guide/browser-support) that Angular supports `CustomElementRegistry` APIs. Side note: `document-register-element` has been deprecated in favor of `@ungap/custom-element` PR Close #43975
alxhub
added a commit
that referenced
this issue
Oct 29, 2021
This test has been removed as since the elements schematic has been removed in a previous commit. PR Close #43975
alxhub
added a commit
that referenced
this issue
Oct 29, 2021
This section was outdated since now all CLI projects are es2015+ and don't require the polyfill since legacy browsers are no longer supported. PR Close #43975
alxhub
added a commit
that referenced
this issue
Oct 29, 2021
This schematic is no longer needed since all the [browsers](https://angular.io/guide/browser-support) that Angular supports `CustomElementRegistry` APIs. Side note: `document-register-element` has been deprecated in favor of `@ungap/custom-element` PR Close #43975
alxhub
added a commit
that referenced
this issue
Oct 29, 2021
This test has been removed as since the elements schematic has been removed in a previous commit. PR Close #43975
gkalpak
added a commit
to gkalpak/angular
that referenced
this issue
Nov 18, 2021
…s examples In PR angular#43975, the `Angular Elements` guide was updated to remove mentions of the Custom Elements-related polyfills, since they are no longer necessary in v13+ (due to all CLI projects being ES2015+ and all supported browsers natively supporting Custom Elements). This commit updates the related docs example boilerplate to not include the unneeded `@webcomponents/custom-elements` polyfill.
jessicajaniuk
added a commit
that referenced
this issue
Nov 19, 2021
…s examples (#44214) In PR #43975, the `Angular Elements` guide was updated to remove mentions of the Custom Elements-related polyfills, since they are no longer necessary in v13+ (due to all CLI projects being ES2015+ and all supported browsers natively supporting Custom Elements). This commit updates the related docs example boilerplate to not include the unneeded `@webcomponents/custom-elements` polyfill. PR Close #44214
gkalpak
added a commit
to gkalpak/angular
that referenced
this issue
Nov 19, 2021
…s examples (angular#44214) In PR angular#43975, the `Angular Elements` guide was updated to remove mentions of the Custom Elements-related polyfills, since they are no longer necessary in v13+ (due to all CLI projects being ES2015+ and all supported browsers natively supporting Custom Elements). This commit updates the related docs example boilerplate to not include the unneeded `@webcomponents/custom-elements` polyfill. PR Close angular#44214
jessicajaniuk
added a commit
that referenced
this issue
Nov 22, 2021
…s examples (#44214) (#44233) In PR #43975, the `Angular Elements` guide was updated to remove mentions of the Custom Elements-related polyfills, since they are no longer necessary in v13+ (due to all CLI projects being ES2015+ and all supported browsers natively supporting Custom Elements). This commit updates the related docs example boilerplate to not include the unneeded `@webcomponents/custom-elements` polyfill. PR Close #44214 PR Close #44233
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
test: remove
ng_elements_schematicsintegration testThis test has been removed as since the elements schematic has been removed in a previous commit.
fix(elements): remove incorrect
@angular/platform-browserpeer dependencyThe elements package doesn't use
@angular/platform-browsertherefore this is not needed.fix(elements): remove
ng-addschematicThis schematic is no longer needed since all the browsers that Angular supports
CustomElementRegistryAPIs.Side note:
document-register-elementhas been deprecated in favor of@ungap/custom-elementdocs: update elements page
This section was outdated since now all CLI projects are es2015+ and don't require the polyfill since legacy browsers are no longer supported.
test: remove
document-register-elementfrom elements testsAll the browsers that Angular supports
CustomElementRegistryAPIsThe text was updated successfully, but these errors were encountered: