Skip to content

feat(@schematics/angular): support pipe name prefix #21801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shaharkazaz
Copy link

like components often you want to prefix your pipes

BREAKING CHANGE: creating a new pipe will prefix the name with the project's prefix if defined

like components often you want to prefix your pipes

BREAKING CHANGE: creating a new pipe will prefix the name with the project's prefix if defined
@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@alan-agius4 alan-agius4 added the needs: discussion On the agenda for team meeting to determine next steps label Jun 2, 2022
@dgp1130
Copy link
Collaborator

dgp1130 commented Jun 16, 2022

The style guide does not include names, and we try to follow that as closely as we can. @jelbourn I know you're looking at updating the style guide, maybe this is a change we should consider making? If so we can revive this PR to match.

@dgp1130 dgp1130 closed this Jun 16, 2022
@alan-agius4 alan-agius4 removed the needs: discussion On the agenda for team meeting to determine next steps label Jun 16, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants