Skip to content

makefile: remove unused SGI_ABI variable #29325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Oct 29, 2021

SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] #3294

Signed-off-by: Filipe Laíns lains@riseup.net

SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] python#3294

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 requested a review from ambv October 29, 2021 20:54
@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 2, 2021
@ambv ambv merged commit 38982ab into python:main Nov 2, 2021
@miss-islington
Copy link
Contributor

Thanks @FFY00 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2021
SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] python#3294

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 38982ab)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 2, 2021
@bedevere-bot
Copy link

GH-29368 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2021
SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] python#3294

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 38982ab)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@bedevere-bot
Copy link

GH-29370 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 2, 2021
ambv pushed a commit that referenced this pull request Nov 2, 2021
SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] #3294

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 38982ab)

Co-authored-by: Filipe Laíns <lains@riseup.net>
ambv pushed a commit that referenced this pull request Nov 2, 2021
SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] #3294

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 38982ab)

Co-authored-by: Filipe Laíns <lains@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants