fix docstring typo in bdb.py #22323

flizzywine · 2020-09-19T16:36:49Z

No description provided.

fix typo

Update bdb.py to fix a typo

the-knights-who-say-ni · 2020-09-19T16:36:52Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@flizzywine

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

aeros

Thanks for the PR @flizzywine, and welcome!

LGTM. I think this is small enough to merge without CLA signed, but it's preferred to sign it if you're willing/able to do so (especially if there's some interest in future contributions).

iritkatriel · 2020-09-20T18:37:41Z

You need to sign the CLA before your changes can be merged. See https://devguide.python.org/pullrequest/?highlight=cla#licensing

aeros · 2020-09-20T23:08:48Z

@iritkatriel The general policy is to allow minor, non-creative fixes (such as typo fixes) without CLA, but it's at the discretion of the core developer merging the change. I'm currently waiting on a response from the author (there are some legitimate cases where people can't sign the CLA due to employer contracts or similar issues).

miss-islington · 2021-05-16T23:20:36Z

Thanks @flizzywine for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

(cherry picked from commit be54fb5) Co-authored-by: flizzywine <1041958497@qq.com>

bedevere-bot · 2021-05-16T23:20:47Z

GH-26179 is a backport of this pull request to the 3.10 branch.

bedevere-bot · 2021-05-16T23:20:52Z

GH-26180 is a backport of this pull request to the 3.9 branch.

(cherry picked from commit be54fb5) Co-authored-by: flizzywine <1041958497@qq.com>

bedevere-bot · 2021-05-16T23:55:14Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.x has failed when building commit be54fb5.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/366/builds/232) and take a look at the build logs.
Check if the failure is related to this commit (be54fb5) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/366/builds/232

Failed tests:

test_importlib

Failed subtests:

test_multiprocessing_pool_circular_import - test.test_importlib.test_threaded_import.ThreadedImportTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 47 sec
test_unparse: 2 min 50 sec
test_multiprocessing_spawn: 2 min 33 sec
test_tokenize: 2 min 12 sec
test_lib2to3: 2 min 3 sec
test_asyncio: 1 min 48 sec
test_multiprocessing_forkserver: 1 min 46 sec
test_unicodedata: 1 min 36 sec
test_capi: 1 min 33 sec
test_pickle: 1 min 3 sec

1 test failed:
test_importlib

18 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_smtpnet test_spwd
test_ssl test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_importlib

Total duration: 31 min 21 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/test_importlib/test_threaded_import.py", line 258, in test_multiprocessing_pool_circular_import
    script_helper.assert_python_ok(fn)
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/support/script_helper.py", line 160, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/support/script_helper.py", line 145, in _assert_python
    res.fail(cmd_line)
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/support/script_helper.py", line 72, in fail
    raise AssertionError("Process return code is %d\n"
AssertionError: Process return code is 1
command line: ['/Users/buildbot/buildarea/3.x.billenstein-macos/build/python.exe', '-X', 'faulthandler', '-I', '/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/test_importlib/partial/pool_in_threads.py']


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/test_importlib/partial/pool_in_threads.py", line 9, in t
    with multiprocessing.Pool(1):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/context.py", line 119, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild,
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/pool.py", line 212, in __init__
    self._repopulate_pool()
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/pool.py", line 303, in _repopulate_pool
    return self._repopulate_pool_static(self._ctx, self.Process,
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/pool.py", line 326, in _repopulate_pool_static
    w.start()
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/process.py", line 121, in start
    self._popen = self._Popen(self)
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/context.py", line 284, in _Popen
    return Popen(process_obj)
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/popen_spawn_posix.py", line 32, in __init__
    super().__init__(process_obj)
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/popen_spawn_posix.py", line 53, in _launch
    parent_r, child_w = os.pipe()
OSError: [Errno 24] Too many open files
/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 118 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-qg4yns3q': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-64sx3mhp': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-7ifnd4ev': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-0lamfbzd': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
---

flizzywine added 2 commits September 20, 2020 00:31

Update bdb.py

1bb744e

fix typo

Merge pull request #1 from flizzywine/flizzywine-patch-1

9baaa52

Update bdb.py to fix a typo

the-knights-who-say-ni added the CLA not signed label Sep 19, 2020

bedevere-bot added the awaiting review label Sep 19, 2020

flizzywine changed the title ~~bpo: fix typo in bdb.py~~ fix typo in bdb.py Sep 19, 2020

aeros added the docs Documentation in the Doc dir label Sep 20, 2020

aeros approved these changes Sep 20, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Sep 20, 2020

aeros added skip issue skip news labels Sep 20, 2020

iritkatriel approved these changes Sep 20, 2020

View reviewed changes

csabella removed the CLA not signed label Sep 21, 2020

the-knights-who-say-ni added the CLA not signed label Sep 21, 2020

aeros removed the CLA not signed label Sep 23, 2020

the-knights-who-say-ni added the CLA not signed label Sep 23, 2020

iritkatriel changed the title ~~fix typo in bdb.py~~ fix docstring typo in bdb.py May 16, 2021

iritkatriel added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 16, 2021

iritkatriel merged commit be54fb5 into python:main May 16, 2021

bedevere-bot removed the awaiting merge label May 16, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2021

fix docstring typo in bdb.py (pythonGH-22323)

a8d2218

(cherry picked from commit be54fb5) Co-authored-by: flizzywine <1041958497@qq.com>

bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes labels May 16, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2021

fix docstring typo in bdb.py (pythonGH-22323)

32fedbc

(cherry picked from commit be54fb5) Co-authored-by: flizzywine <1041958497@qq.com>

iritkatriel pushed a commit that referenced this pull request May 16, 2021

fix docstring typo in bdb.py (GH-22323) (#26179)

d22fa22

(cherry picked from commit be54fb5) Co-authored-by: flizzywine <1041958497@qq.com>

iritkatriel pushed a commit that referenced this pull request May 16, 2021

fix docstring typo in bdb.py (GH-22323) (#26180)

f84ef3c

(cherry picked from commit be54fb5) Co-authored-by: flizzywine <1041958497@qq.com>

pablogsal mentioned this pull request Jul 18, 2021

[3.10] Correct the order of regen-abidump #27228

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix docstring typo in bdb.py #22323

fix docstring typo in bdb.py #22323

Uh oh!

flizzywine commented Sep 19, 2020

Uh oh!

the-knights-who-say-ni commented Sep 19, 2020

Uh oh!

aeros left a comment

Uh oh!

iritkatriel commented Sep 20, 2020

Uh oh!

aeros commented Sep 20, 2020

Uh oh!

miss-islington commented May 16, 2021

Uh oh!

bedevere-bot commented May 16, 2021

Uh oh!

bedevere-bot commented May 16, 2021

Uh oh!

bedevere-bot commented May 16, 2021

Uh oh!

Uh oh!

Uh oh!

fix docstring typo in bdb.py #22323

fix docstring typo in bdb.py #22323

Uh oh!

Conversation

flizzywine commented Sep 19, 2020

Uh oh!

the-knights-who-say-ni commented Sep 19, 2020

Recognized GitHub username

Uh oh!

aeros left a comment

Choose a reason for hiding this comment

Uh oh!

iritkatriel commented Sep 20, 2020

Uh oh!

aeros commented Sep 20, 2020

Uh oh!

miss-islington commented May 16, 2021

Uh oh!

bedevere-bot commented May 16, 2021

Uh oh!

bedevere-bot commented May 16, 2021

Uh oh!

bedevere-bot commented May 16, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!