Skip to content

bpo-45155: Apply new byteorder default values for int.to/from_bytes #28465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2021
Merged

bpo-45155: Apply new byteorder default values for int.to/from_bytes #28465

merged 5 commits into from
Sep 20, 2021

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Sep 20, 2021 •
edited by bedevere-bot
Loading

The code is a little faster and a little more readable with the new default value for byteorder.

Added comments to point of endianess in cases where it might matter.

https://bugs.python.org/issue45155

@rhettinger rhettinger added performance Performance or resource usage skip issue skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Sep 20, 2021
@rhettinger rhettinger requested a review from tiran as a code owner September 20, 2021 06:23
vstinner
vstinner approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just added a minor suggestion.

For the commit message, you can reuse "bpo-45155: " to give more context to the change.

@ambv ambv removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 20, 2021
serhiy-storchaka
serhiy-storchaka reviewed Sep 20, 2021
View reviewed changes
@rhettinger rhettinger changed the title Apply new byteorder default values for int.to/from_bytes bpo-45155: Apply new byteorder default values for int.to/from_bytes Sep 20, 2021
rhettinger and others added 3 commits September 20, 2021 12:48
@rhettinger @vstinner
Update Lib/uuid.py
f996f3b 
Co-authored-by: Victor Stinner <vstinner@python.org>
@rhettinger @serhiy-storchaka
Update Lib/hashlib.py
17a0b68 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@rhettinger @serhiy-storchaka
Update Lib/hashlib.py
331282c 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@rhettinger rhettinger merged commit 9510e6f into python:main Sep 20, 2021
@rhettinger rhettinger deleted the random_from_bytes branch September 20, 2021 18:23
niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
@rhettinger @niyas-sait
bpo-45155: Apply new byteorder default values for int.to/from_bytes (p…
9489fe0 
…ythonGH-28465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv ambv left review comments

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees
No one assigned
Labels
performance Performance or resource usage skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhettinger @ambv @vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot