Stop running VE test on CI and begin throwing an error when compiling with VE #43862

josephperrott · 2021-10-15T21:49:38Z

See individual commits.

At a high level, this PR removes the majority of the configuration within our own infrastructure for running view engine test and ivy tests separately. As Ivy is to be used everywhere, all tests on CI assume Ivy usage even without describing as such.

Additionally, this PR includes the commit proposed in #43857 to begin throwing an error when compiling with VE, showing passing CI with this blocker in place.

josephperrott · 2021-10-15T23:31:36Z

Caretaker Note:

This PR will need to land immediately following the submission of: cl/403493194

dgp1130

Looks great! Just a couple commits with merge conflicts.

Also the last commit message seems to be missing a word or two?

"Both test targets fail because they at test time on view engine, even when run with Ivy built dependencies."

.circleci/config.yml

IgorMinar

Overall this looks great! I found a few things I'm unsure of and I'd like to discuss - only minor stuff.

Thank you Joey!

package.json

.circleci/config.yml

packages/core/schematics/test/BUILD.bazel

docs/DEVELOPER.md

IgorMinar

I found a few small nits, but overall LGTM

Reviewed-for: global-approvers

.circleci/config.yml

packages/bazel/test/ng_package/BUILD.bazel

AndrewKushnir · 2021-10-19T17:07:02Z

This PR was merged into the repository by commit fbd2e4f.

Since building with ViewEngine is not longer desired on CI, removing the ivy vs non-ivy testing yarn scripts is done, informing developers to instead use `yarn test` as all tests should be run using the Ivy complier. PR Close #43862

Using the tag "view-engine-only" better describes the expected usage of bazel targets with the test. They can only be run with view engine. PR Close #43862

Because all actions are assumed to be running on Ivy, things which only work on Ivy should not be marked as Ivy only. PR Close #43862

Remove the fixme-ivy-aot tag filter from usage as no targets are tagged with fixme-ivy-aot as ivy is now the compiler used by default. PR Close #43862

Remove the ivy-aot bazel tag from usage as it served a duplicate purpose as ivy-only which is now removed as both are unneeded with Ivy as the default compiler used. PR Close #43862

Remove the view engine specific saucelabs test job and associated tags/tooling as view engine is no longer being tested on CI. PR Close #43862

Remove the windows view engine test job as view engine is no longer being tested on CI. PR Close #43862

Remove the view engine test job as view engine is no longer being tested on CI. Additionally, update size tracking to rely on test job instead of test_ivy_aot. PR Close #43862

) Removing the comment related about building the npm packages using view engine as it was actually done via ivy, now that ivy is used for all builds there is no need for expressing the aspect of the build. PR Close #43862

…e. (#43862) The View Engine compiler now throws when constructed and will be removed shortly. Direct users should switch to `NgtscProgram` to build with [Ivy](https://angular.io/guide/ivy). The View Engine compiler is being removed, so this makes it throw an error to ensure no one accidentally depends on code being removed. PR Close #43862

…h test as view engine only (#43862) Both test targets fail because, at test time, they use the view engine compiler, even when bazel sets the configuration to use ivy. PR Close #43862

Setting the angular_ivy_enabled environment variable to True will default Bazel builds to use the Ivy compiler rather than defaulting to ViewEngine. PR Close #43862