Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve documentation #44031

Closed
wants to merge 1 commit into from
Closed

docs: improve documentation #44031

wants to merge 1 commit into from

Conversation

Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@A-5ingh
Copy link
Contributor

@A-5ingh A-5ingh commented Nov 3, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

@google-cla google-cla bot commented Nov 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Loading

@google-cla google-cla bot added the cla: no label Nov 3, 2021
@pullapprove pullapprove bot requested a review from gkalpak Nov 3, 2021
@A-5ingh
Copy link
Contributor Author

@A-5ingh A-5ingh commented Nov 3, 2021

@googlebot I signed it!

Loading

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 3, 2021
@bampakoa
Copy link
Contributor

@bampakoa bampakoa commented Nov 3, 2021

Hey @A-5ingh 👋, not sure why file an issue is different than report 😕 I think that the former is a valid word for filing/reporting issues, bugs, and other things.

Loading

@A-5ingh
Copy link
Contributor Author

@A-5ingh A-5ingh commented Nov 3, 2021

Hey @A-5ingh 👋, not sure why file an issue is different than report 😕 I think that the former is a valid word for filing/reporting issues, bugs, and other things.

Hi there @bampakoa for some reason file a bug/defect/issue didn't sound right while reading the doc. Mostly have seen usage of either report or log bug/defect, Ha 😃 I could be wrong too. But in my opinion, I felt report sound much better than file, even though it is a tiny change.

Loading

gkalpak
gkalpak approved these changes Nov 5, 2021
Copy link
Member

@gkalpak gkalpak left a comment

Thx for submitting the PR, @A-5ingh!

As @bampakoa said, both file and report work fine here. As a non-native English speaker, I also prefer report, so let's go with that 😃

Loading

@ngbot ngbot bot added this to the Backlog milestone Nov 5, 2021
@ngbot ngbot bot added this to the Backlog milestone Nov 5, 2021
@ngbot ngbot bot added this to the Backlog milestone Nov 5, 2021
@ngbot ngbot bot added this to the Backlog milestone Nov 5, 2021
@atscott
Copy link
Contributor

@atscott atscott commented Nov 5, 2021

This PR was merged into the repository by commit 3507279.

Loading

atscott added a commit that referenced this issue Nov 5, 2021
@atscott atscott closed this in 3507279 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment