Skip to content

DOC Improves explanation for default value change procedures #21629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Feb 2, 2022
Merged

DOC Improves explanation for default value change procedures #21629

merged 1 commit into from Feb 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2021

Fixes #21467 @reshamas @anonymousr007 @NicolasHug

Adapted the explanations for warnings when changing a default value to make it clearer that the warning message example given assumes that the user is using a soon to be updated version

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title Adapted the explanations for default value change procedures DOC Adapted the explanations for default value change procedures Feb 2, 2022
@thomasjpfan thomasjpfan changed the title DOC Adapted the explanations for default value change procedures DOC Improves explanation for default value change procedures Feb 2, 2022
@thomasjpfan thomasjpfan merged commit 5c01ac3 into scikit-learn:main Feb 2, 2022
@ghost ghost deleted the doc_dev_fix_contrib branch February 2, 2022 17:09
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] clarify version change deprecation
3 participants