Remove _bootsubprocess workaround #29645
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ``_bootsubprocess`` module was added to solve a bootstrapping issue with subprocess module on POSIX. The ``_posixsubprocess`` is now a built-in module and always available in ``setup.py``. Signed-off-by: Christian Heimes <christian@python.org>
|
The subprocess module uses select C extension and selector Python module. The math code in selector could be replaced with |
gpshead
approved these changes
Nov 19, 2021
|
If _posixsubprocess is always available when setup.py is called, I'm fine with removing _bootsubprocess. If I recall correctly, I wrote _bootsubprocess for AIX. But I forgot about the details :-) It was to be able to use subprocess in distutils, rather than a custom code using fork+exec: subprocess is safer and more reliable. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Trigger CLA |
|
Closing as wontfix. It's too late to merge the change into 3.11 and we are going to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_bootsubprocessmodule was added to solve a bootstrapping issuewith subprocess module on POSIX. The
_posixsubprocessis now a built-inmodule and always available in
setup.py.Signed-off-by: Christian Heimes christian@python.org