Skip to content

docs: improve the component styling guide #44234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs: improve the component styling guide #44234

wants to merge 1 commit into from

Conversation

twerske
Copy link
Contributor

@twerske twerske commented Nov 19, 2021

Add component styling guide for customization based on #42251 (comment)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

@twerske twerske added aio: preview target: patch This PR is targeted for the next patch release labels Nov 19, 2021
@twerske twerske requested a review from jelbourn November 19, 2021 21:30
@twerske twerske self-assigned this Nov 19, 2021
@pullapprove pullapprove bot requested a review from alxhub November 19, 2021 21:31
@google-cla google-cla bot added the cla: yes label Nov 19, 2021
@mary-poppins
Copy link

You can preview 09c9af9 at https://pr44234-09c9af9.ngbuilds.io/.

@ngbot ngbot bot added this to the Backlog milestone Nov 19, 2021
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff 😄

@twerske twerske added the action: merge The PR is ready for merge by the caretaker label Nov 30, 2021
@ngbot
Copy link

ngbot bot commented Nov 30, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: setup" is failing
    pending status "pullapprove" is pending
    pending missing required status "ci/circleci: build"
    pending missing required status "ci/circleci: lint"
    pending missing required status "ci/angular: size"
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@twerske twerske removed the action: merge The PR is ready for merge by the caretaker label Nov 30, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twerske twerske removed the request for review from alxhub January 7, 2022 17:42
@pullapprove pullapprove bot requested a review from jessicajaniuk January 7, 2022 17:42
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍪

@twerske twerske added the action: merge The PR is ready for merge by the caretaker label Jan 7, 2022
@ngbot
Copy link

ngbot bot commented Jan 7, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: setup" is failing
    pending missing required status "ci/circleci: build"
    pending missing required status "ci/circleci: lint"
    pending missing required status "ci/angular: size"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins
Copy link

You can preview 334e11a at https://pr44234-334e11a.ngbuilds.io/.

@atscott
Copy link
Contributor

atscott commented Jan 10, 2022

This PR was merged into the repository by commit c82e541.

@atscott atscott closed this in c82e541 Jan 10, 2022
atscott pushed a commit that referenced this pull request Jan 10, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants