Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix/begin trx disjoint #14641

Merged
merged 5 commits into from Aug 16, 2021
Merged

Bug fix/begin trx disjoint #14641

merged 5 commits into from Aug 16, 2021

Conversation

@mchacki
Copy link
Contributor

@mchacki mchacki commented Aug 16, 2021

Scope & Purpose

Fix handling of Disjoint Smart Edge Collections during _api/transaction/begin calls

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required
  • Backports required for: 3.8, 3.7

Related Information

(Please reference tickets / specification / other PRs etc)

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:

Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the HTTP API
  • Added Swagger examples for the HTTP API
  • Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

@mchacki mchacki added the 1 Bug label Aug 16, 2021
@mchacki mchacki requested a review from goedderz Aug 16, 2021
@mchacki mchacki self-assigned this Aug 16, 2021
js/common/modules/jsunity.js Outdated Show resolved Hide resolved
@mchacki
Copy link
Contributor Author

@mchacki mchacki commented Aug 16, 2021

Jenkins was blue, besides the currently known Issue con Mac with Jenkins

@mchacki mchacki merged commit 94aba32 into devel Aug 16, 2021
@mchacki mchacki deleted the bug-fix/begin-trx-disjoint branch Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants