Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45890: Add tests for tracing try-except-finally blocks #29746

Merged
merged 2 commits into from Dec 7, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 24, 2021

@markshannon
Copy link
Member

markshannon commented Nov 24, 2021

OOI, what is the reason for adding these to test_trace, instead of test.test_sys_settrace?
E.g. https://github.com/python/cpython/blob/main/Lib/test/test_sys_settrace.py#L638

The expected output in test.test_sys_settrace is stricter (as it is ordered) and a clearer, IMO.

@iritkatriel
Copy link
Member Author

iritkatriel commented Nov 24, 2021

I didn't notice test.test_sys_settrace, let me check.

@iritkatriel
Copy link
Member Author

iritkatriel commented Nov 24, 2021

test.test_sys_settrace. has some of these, maybe I can add a case or two.

Why are the tests there numbered? Can I change the numbers?

@markshannon
Copy link
Member

markshannon commented Dec 7, 2021

Thanks

@markshannon markshannon merged commit a310fd8 into python:main Dec 7, 2021
10 of 11 checks passed
@iritkatriel iritkatriel deleted the bpo-45890 branch Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants