Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45561: Run smelly.py tool from $(srcdir) (GH-29138) #29138

Merged
merged 2 commits into from Nov 23, 2021
Merged

bpo-45561: Run smelly.py tool from $(srcdir) (GH-29138) #29138

merged 2 commits into from Nov 23, 2021

Conversation

nascheme
Copy link
Member

@nascheme nascheme commented Oct 21, 2021 •
edited by bedevere-bot

@github-actions
Copy link

github-actions bot commented Nov 21, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 21, 2021
@nascheme nascheme removed the stale Stale PR or inactive for long period of time. label Nov 23, 2021
@nascheme
Copy link
Member Author

nascheme commented Nov 23, 2021

Someone fixed the multissltests.py test but smelly.py is still run from wrong path (if building from separate dir).

@nascheme nascheme changed the title bpo-45561: Run smelly.py and multissltests.py from $(srcdir) bpo-45561: Run smelly.py tool from $(srcdir) Nov 23, 2021
@nascheme nascheme requested a review from vstinner Nov 23, 2021
@tiran
Copy link
Member

tiran commented Nov 23, 2021

Someone fixed the multissltests.py test but smelly.py is still run from wrong path (if building from separate dir).

I did. Looks like we ran into the same problem.

tiran
tiran approved these changes Nov 23, 2021
View changes
@tiran tiran changed the title bpo-45561: Run smelly.py tool from $(srcdir) bpo-45561: Run smelly.py tool from $(srcdir) (GH-29138) Nov 23, 2021
@tiran tiran merged commit 457e6a6 into python:main Nov 23, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 23, 2021

Thanks @nascheme for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2021
@nascheme @miss-islington
bpo-45561: Run smelly.py tool from $(srcdir) (pythonGH-29138)
4db6de7 
(cherry picked from commit 457e6a6)

Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 23, 2021

GH-29719 is a backport of this pull request to the 3.10 branch.

@vstinner
Copy link
Member

vstinner commented Nov 23, 2021

Oh, I missed this PR. I didn't test it, but thanks for the fix :-)

miss-islington added a commit that referenced this pull request Nov 23, 2021
@miss-islington @nascheme
bpo-45561: Run smelly.py tool from $(srcdir) (GH-29138)
327c764 
(cherry picked from commit 457e6a6)

Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@nascheme @remykarem
bpo-45561: Run smelly.py tool from $(srcdir) (pythonGH-29138)
12f45b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

@vstinner vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nascheme @tiran @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni