Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45568: Actually use @asynccontextmanager in usage example #29151

Merged
merged 1 commit into from Nov 25, 2021
Merged

bpo-45568: Actually use @asynccontextmanager in usage example #29151

merged 1 commit into from Nov 25, 2021

Conversation

@zsiciarz
Copy link
Contributor

@zsiciarz zsiciarz commented Oct 22, 2021 •
edited by miss-islington
Loading

https://bugs.python.org/issue45568

https://bugs.python.org/issue45568

Automerge-Triggered-By: GH:asvetlov
@zsiciarz zsiciarz requested a review from 1st1 as a code owner Oct 22, 2021
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Oct 22, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@zsiciarz

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Loading

@github-actions
Copy link

@github-actions github-actions bot commented Nov 24, 2021

This PR is stale because it has been open for 30 days with no activity.

Loading

@github-actions github-actions bot added the stale label Nov 24, 2021
asvetlov
asvetlov approved these changes Nov 25, 2021
View changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Thanks!

Loading

@asvetlov asvetlov closed this Nov 25, 2021
@asvetlov asvetlov reopened this Nov 25, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 25, 2021

@zsiciarz: Status check is done, and it's a success ✅ .

Loading

@miss-islington miss-islington merged commit 4dd8219 into python:main Nov 25, 2021
12 checks passed
Loading
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 25, 2021

Thanks @zsiciarz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Loading

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 25, 2021

Sorry @zsiciarz, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4dd82194f4a0e48a94191655e571b3aad1c4a22a 3.10

Loading

@miss-islington miss-islington self-assigned this Nov 25, 2021
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 25, 2021

GH-29779 is a backport of this pull request to the 3.10 branch.

Loading

asvetlov added a commit to asvetlov/cpython that referenced this issue Nov 25, 2021
@zsiciarz @asvetlov
[3.10] bpo-45568: Actually use @asynccontextmanager in usage example (p…
f383477 
…ythonGH-29151)

Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit 4dd8219)

Co-authored-by: Zbigniew Siciarz <zbigniew@siciarz.net>
asvetlov added a commit that referenced this issue Nov 25, 2021
@zsiciarz @asvetlov
[3.10] bpo-45568: Actually use @asynccontextmanager in usage example (G…
52d10f6 
…H-29151) (GH-29779)

Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit 4dd8219)

Co-authored-by: Zbigniew Siciarz <zbigniew@siciarz.net>

Co-authored-by: Zbigniew Siciarz <zbigniew@siciarz.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@1st1 1st1

Assignees

@miss-islington miss-islington

Labels
CLA signed 🤖 automerge skip news stale type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@zsiciarz @the-knights-who-say-ni @miss-islington @bedevere-bot @asvetlov