Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45893: Add missing extern C to initconfig.h (GH-29761) #29761

Merged
merged 2 commits into from Nov 24, 2021
Merged

bpo-45893: Add missing extern C to initconfig.h (GH-29761) #29761

merged 2 commits into from Nov 24, 2021

Conversation

@tiran
Copy link
Member

@tiran tiran commented Nov 24, 2021 •
edited by bedevere-bot
Loading

Co-authored-by: Steve Dower steve.dower@python.org

https://bugs.python.org/issue45893
@tiran @zooba
bpo-45893: Add missing extern C to initconfig.h
6feea3d 
Co-authored-by: Steve Dower <steve.dower@python.org>
gvanrossum
gvanrossum approved these changes Nov 24, 2021
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

What about Steve's other suggestion?

Loading

@tiran
Copy link
Member Author

@tiran tiran commented Nov 24, 2021

What about Steve's other suggestion?

Thanks for the ping. I missed his suggestion. I'll amend the PR.

Loading

@tiran
Copy link
Member Author

@tiran tiran commented Nov 24, 2021

GHA now has:

  python_uwp.cpp
  Generating code
  Finished generating code
  pythonw_uwp.vcxproj -> D:\a\cpython\cpython\PCbuild\amd64\pythonw_uwp.exe

Loading

@tiran tiran changed the title bpo-45893: Add missing extern C to initconfig.h bpo-45893: Add missing extern C to initconfig.h (GH-29761) Nov 24, 2021
@tiran tiran merged commit f4afc53 into python:main Nov 24, 2021
12 checks passed
Loading
@tiran tiran deleted the bpo-45893 branch Nov 24, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 24, 2021

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Loading

miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 24, 2021
@tiran @miss-islington
bpo-45893: Add missing extern C to initconfig.h (pythonGH-29761)
bef04ce 
Co-authored-by: Steve Dower <steve.dower@python.org>
(cherry picked from commit f4afc53)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 24, 2021

GH-29765 is a backport of this pull request to the 3.10 branch.

Loading

miss-islington added a commit that referenced this issue Nov 24, 2021
@tiran @miss-islington
bpo-45893: Add missing extern C to initconfig.h (GH-29761)
cd85d91 
Co-authored-by: Steve Dower <steve.dower@python.org>
(cherry picked from commit f4afc53)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@tiran @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni