Skip to content
master
Switch branches/tags
86 branches 708 tags
Code
Loading

Latest commit

@atscott @dylhunn
atscott and dylhunn fix(language-service): Correctly parse inputs and selectors with doll…
3aafa76 Nov 29, 2021
fix(language-service): Correctly parse inputs and selectors with doll… 
…ar signs (#44268)

When we are going to the definition of an input, we find _both_ the
definition of the input _and_ also look for any directives which have
a selector that matches the input. For example:

```
@directive({
  selector: '[greeting]'
})
export class MyDir {
  @input() greeting!: string;
}
```

With this commit, we now correctly handle the case where inputs and/or
selectors have a dollar sign in them. The dollar sign has special
meaning in CSS, but when we encounter the dollar in a template, we need
to escape it when used as a selector so that it is taken as a dollar
literal rather than a character with special meaning.

Previously, we were not escaping the dollar sign and the CSS parsing
logic would throw an error. The change in this commit prevents that
error from happening, but a `try...catch` is still added in case there
is another unhandled use-case. If this happens, we do not want the
`goToDefinition` operation to completely fail.

Fixes angular/vscode-ng-language-service#1574

PR Close #44268
3aafa76

Git stats

Files

Permalink
Failed to load latest commit information.
Type
Name
Latest commit message
Commit time
.circleci
build: update repository to node@16 locally (#44211)
Nov 24, 2021
.devcontainer
ci: update default circle ci image to cimg/node:14.17.6 (#43810)
Oct 12, 2021
.github
build: update angular (#44241)
Nov 23, 2021
.husky
build: remove unnecessary husky gitignore file (#42870)
Jul 20, 2021
.ng-dev
build: update to the latest version of @angular/dev-infra-private (#4…
Oct 4, 2021
.vscode
docs: added commas to sentences in .vscode/README.md (#43684)
Oct 21, 2021
.yarn
build: update to yarn v1.22.17 (#44150)
Nov 15, 2021
aio
fix(docs-infra): fix the main content layout (#44282)
Nov 29, 2021
docs
docs: fix instructions for debugging a karma test (#44244)
Nov 29, 2021
goldens
refactor: delete the View Engine runtime (#43884)
Nov 23, 2021
integration
refactor(ngcc): remove Ivy switch marker transform (#43891)
Nov 24, 2021
modules
test: remove view-engine-only tests (#43884)
Nov 23, 2021
packages
fix(language-service): Correctly parse inputs and selectors with doll…
Nov 29, 2021
scripts
build: use the latest version of Chrome (v93) in non-bazel tests (#43880
Oct 29, 2021
third_party
build: rename shims_for_IE.js -> shims_for_internal_tests.js (#43002)
Aug 2, 2021
tools
ci: Upgrade tsec to 0.2.0. (#44205)
Nov 24, 2021
.bazelignore
test: delete integration test for language service plugin (#41740)
Apr 23, 2021
.bazelrc
build: remove view engine build infrastructure (#43884)
Nov 23, 2021
.bazelversion
build: remove outdated note when updating bazel version (#42760)
Jul 9, 2021
.clang-format
feat(tooling): Add a .clang-format for automated JavaScript formatting.
Apr 2, 2015
.editorconfig
build: use https link to editorconfig.org in .editorconfig (#27664)
Dec 18, 2018
.gitattributes
build: remove ts-api-guardian from repository (#42735)
Jul 26, 2021
.gitignore
build: Turn tsec checks into bazel tests. (#43108)
Sep 13, 2021
.gitmessage
build: remove dev-infra directory and migrate to relying on @angular/…
Aug 16, 2021
.mailmap
build: add a Git .mailmap with my new name (#19550)
Oct 9, 2017
.npmrc
build: rely on engines to prevent using npm for dependency install (#…
Apr 7, 2021
.nvmrc
build: update repository to node@16 locally (#44211)
Nov 24, 2021
.prettierrc
ci: use prettier to format yml files (#42136)
May 19, 2021
.pullapprove.yml
ci: add jessicajaniuk to pullapprove groups (#44255)
Nov 24, 2021
.yarnrc
build: update to yarn v1.22.17 (#44150)
Nov 15, 2021
BUILD.bazel
build: rename shims_for_IE.js -> shims_for_internal_tests.js (#43002)
Aug 2, 2021
CHANGELOG.md
release: cut the v13.1.0-next.2 release (#44201)
Nov 17, 2021
CODE_OF_CONDUCT.md
docs: add Discord as an official communication channel (#39149)
Oct 14, 2020
CONTRIBUTING.md
docs: fixed minor grammar mistakes in CONTRIBUTING (#43684)
Oct 21, 2021
LICENSE
docs: update the copyright notice date (#40707)
Feb 16, 2021
README.md
docs: improve documentation (#44031)
Nov 5, 2021
WORKSPACE
build: update repository to node@16 locally (#44211)
Nov 24, 2021
browser-providers.conf.js
ci: update mobile browsers tested via browser stack to correctly test…
Nov 5, 2021
gulpfile.js
build: convert CLDR locale extraction from Gulp to Bazel tool (#42230)
Jul 16, 2021
karma-js.conf.js
ci: remove browserstack configuration (#43881)
Oct 18, 2021
package.json
ci: Upgrade tsec to 0.2.0. (#44205)
Nov 24, 2021
renovate.json
ci: instruct renovate to apply patch label to avoid divergence with o…
Nov 9, 2021
test-events.js
build: update license headers to reference Google LLC (#37205)
May 26, 2020
test-main.js
build: remove unnecessary polyfills from tests (#42567)
Jun 14, 2021
tsconfig-tslint.json
build: remove dev-infra directory and migrate to relying on @angular/…
Aug 16, 2021
tslint.json
build: enable esModuleInterop in TypeScript compilations (#43431)
Oct 1, 2021
yarn.lock
ci: Upgrade tsec to 0.2.0. (#44205)
Nov 24, 2021
yarn.lock.readme.md
build: remove travisci leftovers (#27979)
Jan 9, 2019
Angular - The modern web developer's platform. Documentation Advanced Development Setup Prerequisites Setting Up a Project Quickstart Ecosystem Changelog Upgrading Contributing Contributing Guidelines Want to Help? Code of Conduct Community

README.md

Angular - The modern web developer's platform.

angular-logo
Angular is a development platform for building mobile and desktop web applications
using Typescript/JavaScript and other languages.

www.angular.io

Contributing Guidelines · Submit an Issue · Blog

CI status   Angular on npm   Discord conversation

Documentation

Get started with Angular, learn the fundamentals and explore advanced topics on our documentation website.

Advanced

Development Setup

Prerequisites

Setting Up a Project

Install the Angular CLI globally:

npm install -g @angular/cli

Create workspace:

ng new [PROJECT NAME]

Run the application:

cd [PROJECT NAME]
ng serve

Angular is cross-platform, fast, scalable, has incredible tooling, and is loved by millions.

Quickstart

Get started in 5 minutes.

Ecosystem

angular ecosystem logos

Changelog

Learn about the latest improvements.

Upgrading

Check out our upgrade guide to find out the best way to upgrade your project.

Contributing

Contributing Guidelines

Read through our contributing guidelines to learn about our submission process, coding rules and more.

Want to Help?

Want to report a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues labeled as help wanted or good first issue.

Code of Conduct

Help us keep Angular open and inclusive. Please read and follow our Code of Conduct.

Community

Join the conversation and help the community.

Love Angular badge

Love Angular? Give our repo a star ⭐ ⬆️.

About

The modern web developer’s platform

angular.io

Topics

javascript angular typescript web-performance web pwa web-framework

Resources

Readme

License

MIT License

Code of conduct

Code of conduct

Releases 119

v13.0.2 Latest
Nov 17, 2021
+ 118 releases

Packages

No packages published

Used by 2.1m

  • @man18008
  • @mikaelangelo12
  • @Jamilett
  • @christin-xaviour
  • @Julicons
  • @LBechara
  • @khenxiety
  • @nguyenduc96
+ 2,056,695

Contributors 1,497

+ 1,486 contributors

Languages