Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update the build system to the latest structure #1729

Merged
merged 4 commits into from Apr 27, 2020
Merged

build: update the build system to the latest structure #1729

merged 4 commits into from Apr 27, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Apr 25, 2020

Close #1253

This PR updates the build system to align with the latest Vue libs. Almost identical to how it is in Vuex 4. The differences are:

  • Bundle name is as is.
  • UMD build instead of IIFE.

@kiaking kiaking added the build label Apr 25, 2020
@kiaking kiaking requested a review from ktsn Apr 25, 2020
@kiaking kiaking self-assigned this Apr 25, 2020
@kiaking kiaking mentioned this pull request Apr 26, 2020
Closed
@kiaking
Copy link
Member Author

@kiaking kiaking commented Apr 26, 2020

Added global __DEV__ support to prevent issue #1730 from happening.

ktsn
ktsn reviewed Apr 26, 2020
View changes
.gitignore Outdated Show resolved Hide resolved
ktsn
ktsn requested changes Apr 27, 2020
View changes
Copy link
Member

@ktsn ktsn left a comment

Sorry for the split review but I found a few issues in the build script.

rollup.config.js Outdated Show resolved Hide resolved
rollup.main.config.js Outdated Show resolved Hide resolved
ktsn
ktsn approved these changes Apr 27, 2020
View changes
Copy link
Member

@ktsn ktsn left a comment

LGTM, thanks!

@ktsn ktsn merged commit d98ea64 into dev Apr 27, 2020
6 checks passed
@ktsn ktsn deleted the build-system branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn

Assignees

@kiaking kiaking

Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiaking @ktsn