Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45881: Use CC from env first for cross building (GH-29752) #29752

Merged
merged 1 commit into from Nov 24, 2021

Conversation

@tiran
Copy link
Member

@tiran tiran commented Nov 24, 2021

setup.py now uses CC from environment first to discover multiarch
and cross compile paths. The sysconfig variable contains the value for
the build host.

The patch also re-arranges set_compiler_executables,
configure_compiler, and init_inc_lib_dirs to make the code
easier to follow.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45881

``setup.py`` now uses ``CC`` from environment first to discover multiarch
and cross compile paths. The sysconfig variable contains the value for
the build host.

The patch also re-arranges ``set_compiler_executables``,
``configure_compiler``, and ``init_inc_lib_dirs`` to make the code
easier to follow.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the bpo-45881-cross-cc branch from acc610b to 0719057 Nov 24, 2021
@tiran tiran changed the title bpo-45881: Use CC from env first for cross building bpo-45881: Use CC from env first for cross building (GH-29752) Nov 24, 2021
@tiran tiran merged commit b30bf45 into python:main Nov 24, 2021
11 of 12 checks passed
Loading
@tiran tiran deleted the bpo-45881-cross-cc branch Nov 24, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 24, 2021

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

Loading

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 24, 2021

Sorry, @tiran, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b30bf4520ae9d6e7eca09d812dd8a86c020b9202 3.10

Loading

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 24, 2021

Sorry @tiran, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b30bf4520ae9d6e7eca09d812dd8a86c020b9202 3.9

Loading

tiran added a commit to tiran/cpython that referenced this issue Nov 24, 2021
…29752).

(cherry picked from commit b30bf45)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit to tiran/cpython that referenced this issue Nov 24, 2021
…honGH-29752).

(cherry picked from commit b30bf45)

Co-authored-by: Christian Heimes <christian@python.org>.
(cherry picked from commit e6b0c8a)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 24, 2021

GH-29754 is a backport of this pull request to the 3.9 branch.

Loading

tiran added a commit that referenced this issue Nov 25, 2021
…H-29754)

Co-authored-by: Christian Heimes <christian@python.org>.
Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit that referenced this issue Nov 27, 2021
GH-29753)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 27, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang Installed 3.10 has failed when building commit 545aebd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/690/builds/488) and take a look at the build logs.
  4. Check if the failure is related to this commit (545aebd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/690/builds/488

Summary of the results of the build (if available):

Click to see traceback logs
fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 504

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants