[Mailer] Override recipient with mailer.envelope.recipients configuration #41150
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot
changed the title
|
Hey! I think @Koc has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
|
||
| foreach ($envelope->getRecipients() as $key => $recipient) { | ||
| if($key === 0) { | ||
| $originalMessage->to($recipient->getAddress()); |
There was a problem hiding this comment.
For once, I'm going to agree with Psalm! The original message can be a RawMessage for which we don't have any of these conventional methods. In any case, the envelope should never alter the message directly.
This is controlled by line 199 instead.
|
Any update on this bug? |
|
|
Closing in favor of #45690 |
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Use recipients in sendmail transport | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41149 | License | MIT | Doc PR | - Supersedes #41150 Commits ------- 7134e46 [Mailer] Use recipients in sendmail transport
#41149
Symfony/Mailer : The recipients feature ("Always Send to the same Address") does not work with sendmail