New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45696: Deep-freeze #29118
bpo-45696: Deep-freeze #29118
Conversation
Not generating Makefile yet
Still not generating Makefile
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Do you have an example? I don't see any warnings. Unless you mean lines like
which are explicitly printed by the command in the Makefile (instead of the full command, which is several lines long due to the long and repeated filenames). |
The bootstrap interpreter prints two warnings lines when the
There is no cleanup target for the new directory. I think |
I've seen that too, but only in the CI. Maybe it's Linux only? I am at a loss for how to fix it. Should I just set
There's a |
@tiran any idea? |
You could try to use the bootstrap interpreter to generate sysconfig and pybuilddir.txt: main...tiran:deepfreeze-bootstrap In the long run we might be able to replace |
@tiran, Does it look good now? All tests pass. I'll merge origin/main again and re-run the buildbots and then I hope to land this. We'll leave several things to future generations (or at least a later PR):
|
If you want to schedule another build, you need to add the " |
The AMD64 FreeBSD buildbot is failing (https://buildbot.python.org/all/#/builders/203/builds/314/steps/3/logs/stdio), and AFAICT the cause is that its Make doesn't understand |
I was not aware that I'm sorry for the extra work I caused. |
If you want to schedule another build, you need to add the " |
If you want to schedule another build, you need to add the " |
See faster-cpython/ideas#84
This seems to be 10% faster than current main[1], so an improvement over Eric's freeze.
Downside: the data segment grows from 490 KB to 1.3 MB. (We could get ~300 KB back by not including the marshalled-frozen data.)
Another downside, for developers: whenever you touch a source file,
_bootstrap_python
gets rebuilt, and that triggers a rebuild of all the deep-frozen modules. (See comment below for a possible fix.)Haven't gotten it working on Windows yet. (The magic is disabled there for now.) I might do that in a separate PR.
[1] Measured on an x86 Mac, with lto-pgo, this shaves 1.5-2 msec off a total run time of around 14 msec. I measured by using the subprocess to run
python -c pass
100 times.https://bugs.python.org/issue45696
The text was updated successfully, but these errors were encountered: