Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The documentation suggests an invalid value for the name of a secret #12094

Closed
1 task done
lpmi-13 opened this issue Nov 17, 2021 · 5 comments
Closed
1 task done

The documentation suggests an invalid value for the name of a secret #12094

lpmi-13 opened this issue Nov 17, 2021 · 5 comments
Labels
actions content waiting for review
Projects
Docs open source board

Comments

@lpmi-13
Copy link

@lpmi-13 lpmi-13 commented Nov 17, 2021

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions

What part(s) of the article would you like to see updated?

The article contains the following example configuration:

steps:
  - name: My first action
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      FIRST_NAME: Mona
      LAST_NAME: Octocat

However, when attempting to follow this example, I was presented with an error in the UI as follows:

"Failed to add secret. Secret names must not start with GITHUB_."

If this is not a valid naming convention for secrets, then it shouldn't be used in the documentation.

Additional information

error when attempting to create a secret
@lpmi-13 lpmi-13 added the content label Nov 17, 2021
@welcome
Copy link

@welcome welcome bot commented Nov 17, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage label Nov 17, 2021
@github-actions github-actions bot added this to Triage in Docs open source board Nov 17, 2021
@lpmi-13 lpmi-13 mentioned this issue Nov 17, 2021
Closed
5 tasks
@ramyaparimi ramyaparimi removed the triage label Nov 18, 2021
@ramyaparimi ramyaparimi removed this from Triage in Docs open source board Nov 18, 2021
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 17, 2022

A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.

@github-actions github-actions bot added the stale label Jan 17, 2022
@ramyaparimi ramyaparimi added actions waiting for review and removed stale labels Jan 17, 2022
@ramyaparimi
Copy link
Contributor

@ramyaparimi ramyaparimi commented Jan 17, 2022

@lpmi-13 I apologize for the delay in triaging this issue. Once in a while my notifications act wonky 😭
I removed the stale label and triaged this issue for a writer's review 👀 . I truly appreciate your patience 💖.

Thanks so much taking time to make contributions to GitHub docs 💖

@github-actions github-actions bot added this to Triage in Docs open source board Jan 17, 2022
@lpmi-13
Copy link
Author

@lpmi-13 lpmi-13 commented Jan 17, 2022

Hi @ramyaparimi! That's no problem at all. I actually think the corresponding PR was correctly closed earlier, since it seemed to be my error in misunderstanding the docs, so we can go ahead and close this issue.

@ramyaparimi
Copy link
Contributor

@ramyaparimi ramyaparimi commented Jan 18, 2022

@lpmi-13 Thanks so much 💖

Closing as PR linked to this issue was closed.

Docs open source board automation moved this from Triage to Done Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actions content waiting for review
Projects
Docs open source board
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lpmi-13 @ramyaparimi and others