Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] alias cache.app.taggable to cache.app if using cache.adapter.redis_tag_aware #44682

Merged
merged 1 commit into from Dec 17, 2021

Conversation

@kbond
Copy link
Member

@kbond kbond commented Dec 17, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

When using cache.adapter.redis_tag_aware for your cache.app, cache.app.taggable is unnecessarily decorated with TagAwareAdapter. This sets cache.app.taggable as an alias to cache.app in this case.

Alternative to #44673.

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Dec 17, 2021

Good catch, thanks @kbond.

@nicolas-grekas nicolas-grekas merged commit a7e4494 into symfony:5.3 Dec 17, 2021
10 of 12 checks passed
@kbond kbond deleted the cache-app-redis-tag-aware-2 branch Dec 17, 2021
kbond added a commit that referenced this issue Dec 21, 2021
… (kbond)

This PR was merged into the 5.3 branch.

Discussion
----------

[FrameworkBundle] Fix test to actually use data provider

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

#44682 didn't actually use the data provider.

Commits
-------

6cafac4 fix test to actually use data provider
@fabpot fabpot mentioned this pull request Dec 29, 2021
@fabpot fabpot mentioned this pull request Dec 29, 2021
@fabpot fabpot mentioned this pull request Dec 29, 2021
chalasr added a commit that referenced this issue Feb 9, 2022
…gs` command (kbond)

This PR was squashed before being merged into the 6.1 branch.

Discussion
----------

[Cache][FrameworkBundle] add `cache:pool:invalidate-tags` command

| Q             | A
| ------------- | ---
| Branch?       | 6.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #40218
| License       | MIT
| Doc PR        | symfony/symfony-docs#16328

Adds a `cache:pool:invalidate-tags` command.

## Usage

```bash
bin/console cache:pool:invalidate-tags tag1 # invalidates tag1 from all taggable pools
bin/console cache:pool:invalidate-tags tag1 tag2 # invalidates tag1 & tag2 from all taggable pools
bin/console cache:pool:invalidate-tags tag1 tag2 --pool=cache.app # invalidates tag1 & tag2 from cache.app pool
bin/console cache:pool:invalidate-tags tag1 tag2 -p cache1 -p cache2 # invalidates tag1 & tag2 from cache1 & cache2 pools
```

## TODO

- [x] tests
- [x] account for #44682 (once merged up to 6.1)

Commits
-------

0657f14 [Cache][FrameworkBundle] add `cache:pool:invalidate-tags` command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants