[VarDumper] Make dumping DateInterval instances timezone-independent #43867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander M. Turek <me@derrabus.de>
fabpot
approved these changes
Nov 1, 2021
|
Thank you @derrabus. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In our CI, we currently see failing VarDumper tests because the tests have been executed close to the end of DST in Europe. This PR attempts to make dumping
DateIntervalinstances more robust by decoupling the dumper from global timezone settings and the current date.The text was updated successfully, but these errors were encountered: