fix: handle tabview background color in iOS 15 #9617
Conversation
I'll flag as needing additional changes to ensure it doesn't accidentally merge here. I think I'll turn to draft as well.
| this._ios.tabBar.barTintColor = value instanceof Color ? value.ios : value; | ||
| if (majorVersion >= 15) { | ||
| let appearance = UITabBarAppearance.new(); | ||
| appearance.backgroundColor = value instanceof Color ? value.ios : value; |
There was a problem hiding this comment.
Thanks @janoshrubos this is looking pretty good - there's couple other things to consider - I will be posting a PR to ui-material-bottom-navigation to fix the same issue - we also want to ensure the appearance defaults are setup properly outside of only when background is set using the configure api's, for example:
https://developer.apple.com/documentation/uikit/uibarappearance/3197997-configurewithdefaultbackground
This ensures the same expected translucency effect is maintained as it was prior to ios 15.
That api will be used when no background is set and done via initNativeView for TabView here. Then if a background is set here it would then flip it's configuration to opaque:
https://developer.apple.com/documentation/uikit/uibarappearance/3197998-configurewithopaquebackground
There was a problem hiding this comment.
awesome! thanks for the info @NathanWalker, it's much clearer now.
NathanWalker
merged commit cfa65d6
into
NativeScript:release/8.2.0
PR Checklist
What is the current behavior?
In iOS15 the defined
tabBackgroundColorfor theTabViewonly get's initialized correctly for a tab with scrolling content, but to get it initialized correctly you must have switched to another tab at least once before.What is the new behavior?
If there's a defined
tabBackgroundColorit applies the color to a tab with and withoutScrollViewTODO: fix Nathan's change request ui-material-bottom-navigation
Fixes #9614