Skip to content

Optimize: Improve performance using StringBuilder and reducing map lookups #11711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

larrydiamond
Copy link

These are performance improvements with no new functionality.

StringBuilder will perform faster than StringBuffer as synchronization does not need to occur in these locations.
Iterating over an entrySet rather than a keySet and then looking up the entry will eliminate the need for N lookups.

All Submissions:

  • [X ] Have you followed the guidelines in our Contributing document?
  • [X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [X ] Does your submission pass tests?
  2. [X ] Have you lint your code locally prior to submission?

Changes to Core Features:

  • [ NA ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ Existing Tests cover ] Have you written new tests for your core changes, as applicable?
  • [ Yes ] Have you successfully ran tests with your changes

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2021

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added the Component: IDE The Arduino IDE label Nov 30, 2021
@larrydiamond larrydiamond closed this by deleting the head repository Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants