Skip to content

/ editor.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡Use 'text' cursor when there is the only placeholder #1165

Open
nikmel2803 opened this issue May 23, 2020 · 1 comment
Open

💡Use 'text' cursor when there is the only placeholder #1165

nikmel2803 opened this issue May 23, 2020 · 1 comment
Assignees
@nikmel2803
Labels
feature good first issue

Comments

@nikmel2803
Copy link
Member

@nikmel2803 nikmel2803 commented May 23, 2020

  1. Describe a problem.
    When placeholder is displaying it is not intuitive that you can click and edit that content because of the cursor is in standard style
    telegram-cloud-photo-size-2-5352945091536334306-x

  2. Describe the solution you'd like. Mockups are welcome.
    Make cursor: text for editor block when there is the only placeholder
    telegram-cloud-photo-size-2-5352945091536334308-x
@nikmel2803 nikmel2803 added the feature label May 23, 2020
ranemihir added a commit to ranemihir/editor.js that referenced this issue Jun 19, 2020
@ranemihir
Add text cursor on placeholder
4282ce5 
Fixes codex-team#1165

Previously the cursor on placeholder was default which is changed to text
as expected  by the issue.
@ranemihir ranemihir mentioned this issue Jun 19, 2020
Closed
@ranemihir
Copy link
Member

@ranemihir ranemihir commented Aug 18, 2020

@nikmel2803 After testing, I found out that when the cursor is on the placeholder text of the Header tool, it remains in default state which should have been caret. But from what I have observed, the issue only exists with the Header tool itself and I have made PR #1205 fixing the issue. Please check it out and write a review.

Have I misunderstood your issue?

Should the cursor be a caret everywhere for the entire <div id="editorjs"></div>?
Are you talking about that specific block or entire <div id="editorjs"></div>?
Is it related to a specific tool?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikmel2803 nikmel2803

Labels
feature good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Change cursor on placeholder to text from default
3 participants
@neSpecc @nikmel2803 @ranemihir
You can’t perform that action at this time.