Set rel="external" on external links #1643
Open
Conversation
|
Rather than checking for external v. internal twice, why not have Also, the tests need to be updated. |
Yes, ideal, but the code need the original schema, not the returned (local can be a HTTP?), so the best is to use components as parameter.
You can delete this pull request and do yours, was only a suggestion, I have no way to test here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi, please check if it is correct... and perhaps opportunity to some reuse. The focus here was only to suggest a simple solution to the issue #1639, adding the attribute
rel="external"in an<a href>tag that seems not local.