Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Lint SCSS with prettier in pre-commit #15033

Merged
merged 1 commit into from Nov 22, 2021
Merged

DEV: Lint SCSS with prettier in pre-commit #15033

merged 1 commit into from Nov 22, 2021

Conversation

@martin-brennan
Copy link
Contributor

@martin-brennan martin-brennan commented Nov 22, 2021

We are linting SCSS on the GitHub actions CI but not
on pre-commit, which can lead to lint failures in CI.
Better to warn developers about this locally like
our other lints.
@martin-brennan
DEV: Lint SCSS with prettier in pre-commit
7e0406c 
We are linting SCSS on the GitHub actions CI but not
on pre-commit, which can lead to lint failures in CI.
Better to warn developers about this locally like
our other lints.
@martin-brennan martin-brennan merged commit df6003a into main Nov 22, 2021
12 checks passed
@martin-brennan martin-brennan deleted the dev/add-scss-linting branch Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanrizzi romanrizzi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@martin-brennan @romanrizzi