Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Extend plugin API to add multiple poster icons #15311

Merged
merged 4 commits into from Dec 15, 2021
Merged

FEATURE: Extend plugin API to add multiple poster icons #15311

merged 4 commits into from Dec 15, 2021

Conversation

@nattsw
Copy link
Contributor

@nattsw nattsw commented Dec 15, 2021 •
edited

This adds addPosterIcons to the plugin which gives users the ability to loop through any decorator attrs to add multiple icons at once. This new method also is backwards compatible.

This change is tested by an internal plugin that is using it.
@tgxworld
Copy link
Contributor

@tgxworld tgxworld commented Dec 15, 2021

O we also need to bump the PLUGIN_API_VERSION constant in the file.

nattsw and others added 2 commits Dec 15, 2021
@nattsw @tgxworld
Fix documentation
2d46229 
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
@nattsw
Bump plugin api version
f9d7d12 
and include disclaimer in api documentation
@nattsw nattsw merged commit 77781f9 into main Dec 15, 2021
12 checks passed
@nattsw nattsw deleted the add-poster-icons branch Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgxworld tgxworld

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@nattsw @tgxworld