Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code repetition #758

Open
raklaptudirm opened this issue Oct 8, 2021 · 5 comments
Open

Reduce code repetition #758

raklaptudirm opened this issue Oct 8, 2021 · 5 comments
Assignees
@lvlte
Labels
good first issue help wanted In Progress

Comments

@raklaptudirm
Copy link
Member

@raklaptudirm raklaptudirm commented Oct 8, 2021 •
edited
Loading

We have now successfully added guidelines for importing and using algorithms in this repository, inside other algorithms. This has been done to reduce code repetition and uphold code quality. Some functions do implement their own versions of data structures and helper functions, as previously, algorithms were supposed to be completely self contained. This issue initiates a search and fix so that all functions and data structures which can be imported in an algorithm should be imported.

Also as an addition to the topic, this initiative should also weed out bad code, i.e.:

  • Code which does not follow the contributing guidelines.
  • Code with a bad implementation.
  • Bad Code in general.
  • Complicated operations without comments.
@raklaptudirm
Copy link
Member Author

@raklaptudirm raklaptudirm commented Oct 21, 2021

@lvlte @defaude Any of you interested in working on this?

Loading

@lvlte
Copy link
Contributor

@lvlte lvlte commented Oct 21, 2021

Yep sure, I will take a look next week.

Loading

@littlefermatlives
Copy link

@littlefermatlives littlefermatlives commented Oct 22, 2021

Hey, I wanna do it. Please assign it to me.

Loading

@raklaptudirm
Copy link
Member Author

@raklaptudirm raklaptudirm commented Oct 22, 2021

@littlefermatlives Please open a pull request and do the changes. I will review it.

Loading

@RenatoLopes771
Copy link
Contributor

@RenatoLopes771 RenatoLopes771 commented Oct 27, 2021

If anyone finds some of those and either doesn't want to work on them or don't have to knowledge of the function, feel free to share here so others can do it.

I feel like it would also be a good idea for someone to make a checklist on those files that have been throughly checked for these and don't need any more review.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvlte lvlte

Labels
good first issue help wanted In Progress
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@lvlte @RenatoLopes771 @raklaptudirm @littlefermatlives