Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove IE11 from the list of browsers used during CI #43002

Closed
wants to merge 2 commits into from
Closed

ci: remove IE11 from the list of browsers used during CI #43002

wants to merge 2 commits into from

Conversation

Reviewers

@gkalpak gkalpak

@IgorMinar IgorMinar

@JiaLiPassion JiaLiPassion

@devversion devversion

Assignees
No one assigned
Labels
action: merge browser: ie 11 cla: yes comp: build & ci target: major
Projects
None yet
Milestone
Backlog
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@AndrewKushnir @IgorMinar @JiaLiPassion @devversion @gkalpak
@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Jul 30, 2021

Since IE 11 support was deprecated in v12 and will be dropped in v13, this PR removes IE11 from the list of browsers where Angular Framework tests are executed. This PR also removes IE-specific shims that were needed for tests only.

PR Type

What kind of change does this PR introduce?

  • Build related changes
  • CI related changes

Does this PR introduce a breaking change?

  • Yes
  • No
@AndrewKushnir
ci: remove IE11 from the list of browsers used during CI
4575e59 
This commit performs several updates to stop running tests in IE11 on CI (since IE11 support was deprecated in v12 and will be dropped in v13).
@AndrewKushnir
build: rename shims_for_IE.js -> shims_for_internal_tests.js
5cebfe7 
This commit renames shims_for_IE.js -> shims_for_internal_tests.js, since there are no IE shims there anymore (there are still shims for older Safari and Android versions).
@ngbot ngbot bot added this to the Backlog milestone Jul 30, 2021
@ngbot ngbot bot added this to the Backlog milestone Jul 30, 2021
@ngbot ngbot bot added this to the Backlog milestone Jul 30, 2021
@google-cla google-cla bot added the cla: yes label Jul 30, 2021
@AndrewKushnir AndrewKushnir marked this pull request as ready for review Jul 31, 2021
IgorMinar
IgorMinar approved these changes Jul 31, 2021
View changes
Copy link
Member

@IgorMinar IgorMinar left a comment

Yessssssssssssss!

Reviewed-for: global-approvers

Loading

gkalpak
gkalpak reviewed Aug 1, 2021
View changes
Copy link
Member

@gkalpak gkalpak left a comment

🎉

Loading

@AndrewKushnir AndrewKushnir removed the request for review from atscott Aug 2, 2021
@atscott atscott closed this in 892ae85 Aug 2, 2021
atscott added a commit that referenced this issue Aug 2, 2021
@AndrewKushnir @atscott
build: rename shims_for_IE.js -> shims_for_internal_tests.js (#43002)
8861d73 
This commit renames shims_for_IE.js -> shims_for_internal_tests.js, since there are no IE shims there anymore (there are still shims for older Safari and Android versions).

PR Close #43002
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 2, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Loading

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 2, 2021
TeriGlover added a commit to TeriGlover/angular that referenced this issue Sep 22, 2021
@AndrewKushnir @TeriGlover
ci: remove IE11 from the list of browsers used during CI (angular#43002)
5f27681 
This commit performs several updates to stop running tests in IE11 on CI (since IE11 support was deprecated in v12 and will be dropped in v13).

PR Close angular#43002
TeriGlover added a commit to TeriGlover/angular that referenced this issue Sep 22, 2021
@AndrewKushnir @TeriGlover
build: rename shims_for_IE.js -> shims_for_internal_tests.js (angular…
280a36a 
…#43002)

This commit renames shims_for_IE.js -> shims_for_internal_tests.js, since there are no IE shims there anymore (there are still shims for older Safari and Android versions).

PR Close angular#43002
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.