MAINT Use push_back directly in dbscan_inner #22077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Dec 27, 2021
There was a problem hiding this comment.
Indeed, when this adaptation has been introduced (27d4376) scikit-learn was probably not using the latest version of Cython which introduced the exception handling for some containers from libcpp (cython/cython@b44bdbb).
LGTM!
venkyyuvy
pushed a commit
to venkyyuvy/scikit-learn
that referenced
this pull request
Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes helper code and calls
push_backdirectly. Looking at thepush_backimport in Cython:https://github.com/cython/cython/blob/bba69054b4aff2c0a63a8be9d6ce5c9fdd079a52/Cython/Includes/libcpp/vector.pxd#L74
the C++ exception is already converted into a Python exception when
push_backis called.CC @jjerphan
CC @glemaitre I think this is causing the complier issue in conda-forge windows pypy3