-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-45578: add a test case for dis.findlabels
#30058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
approved these changes
Dec 20, 2021
Misc/NEWS.d/next/Tests/2021-12-11-19-14-53.bpo-45578.onff4-.rst
Outdated
Show resolved
Hide resolved
merwok
reviewed
Jan 2, 2022
merwok
reviewed
Jan 2, 2022
@merwok I want to say very big thank you for your time spent reviewing so many my PRs today! I highly appreciate this, especially during the winter holidays. This is awesome! 👍 |
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
40d0058
to
2269953
Compare
taleinat
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ambv, want to take a quick look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45578
CC @ambv as someone who reviewed / merged a previous PR in this series.
Refs #29332