Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validate_solutions and add durations flag to pytest.ini #3704

Merged
merged 5 commits into from Oct 24, 2020

Conversation

Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 24, 2020

Describe your change:

  • Moved validate_solutions.py and project_euler_answers.json to scripts directory and other dependent changes.
  • Configure pytest.ini with the --durations flag to apply it everywhere.
  • Remove codespell and autoblack action as mentioned in #3447 (comment)
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 24, 2020

Moved validate_solutions.py and project_euler_answers.json to scripts directory

If these scripts are only used for GitHub Actions then my preference would be that they live in .github/workflows. Your thoughts?

@dhruvmanila
Copy link
Member Author

@dhruvmanila dhruvmanila commented Oct 24, 2020

I think scripts is an appropriate place for them to be. Also, workflows is a special directory used by GitHub so I don't think we can put other files in it.

pytest.ini Outdated Show resolved Hide resolved
@dhruvmanila dhruvmanila merged commit b97529d into TheAlgorithms:master Oct 24, 2020
4 checks passed
@dhruvmanila dhruvmanila deleted the move-validate-solutions branch Oct 24, 2020
s-okubanjo added a commit to s-okubanjo/Python that referenced this issue Nov 29, 2020
…rithms#3704)

* Move PE validate_solutions to scripts/ directory

* Update pytest.ini file with durations settings

* Remove codespell and autoblack workflow file

* Dependent changes to test config files

* Update pytest.ini
stokhos added a commit to stokhos/Python that referenced this issue Jan 3, 2021
…rithms#3704)

* Move PE validate_solutions to scripts/ directory

* Update pytest.ini file with durations settings

* Remove codespell and autoblack workflow file

* Dependent changes to test config files

* Update pytest.ini
peRFectBeliever added a commit to peRFectBeliever/Python that referenced this issue Apr 1, 2021
…rithms#3704)

* Move PE validate_solutions to scripts/ directory

* Update pytest.ini file with durations settings

* Remove codespell and autoblack workflow file

* Dependent changes to test config files

* Update pytest.ini
Panquesito7 pushed a commit to Panquesito7/Python that referenced this issue May 13, 2021
…rithms#3704)

* Move PE validate_solutions to scripts/ directory

* Update pytest.ini file with durations settings

* Remove codespell and autoblack workflow file

* Dependent changes to test config files

* Update pytest.ini
shermanhui added a commit to shermanhui/Python that referenced this issue Oct 22, 2021
…rithms#3704)

* Move PE validate_solutions to scripts/ directory

* Update pytest.ini file with durations settings

* Remove codespell and autoblack workflow file

* Dependent changes to test config files

* Update pytest.ini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment