TheAlgorithms / Python Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite parts of Vector and Matrix #5362
Conversation
Also I noticed that Vector's euclidLength and magnitude methods both do the same thing. Should I open an issue to have one of them removed? |
Refactor determinant method to create separate minor and cofactor methods. Add respective unit tests for new methods. Rename methods using snake case to follow Python naming conventions.
I had to edit multiple files because I wrote unit tests for my new methods and renamed some existing methods |
Co-authored-by: John Law <johnlaw.po@gmail.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
Let's keep |
Let's get this merged for now. Thank you for your pull request!
Describe your change:
Rewrote parts of Vector and Matrix and added unit tests as needed
Checklist:
Fixes: #{$ISSUE_NO}
.The text was updated successfully, but these errors were encountered: