Implementation of SHA-256 using Python #5532
Conversation
![algorithms-keeper[bot]](https://web.archive.org/web/20211029142356im_/https://avatars.githubusercontent.com/in/86183?s=60&v=4){kind=small}
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
added
awaiting changes
tests are failing
and removed
awaiting reviews
labels
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Test class for the SHA256 class. Inherits the TestCase class from unittest | ||
| """ | ||
|
|
||
| def test_match_hashes(self) -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function test_match_hashes
| self.assertEqual(SHA256(msg).hash, hashlib.sha256(msg).hexdigest()) | ||
|
|
||
|
|
||
| def main() -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function main
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Test class for the SHA256 class. Inherits the TestCase class from unittest | ||
| """ | ||
|
|
||
| def test_match_hashes(self) -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function test_match_hashes
| self.assertEqual(SHA256(msg).hash, hashlib.sha256(msg).hexdigest()) | ||
|
|
||
|
|
||
| def main() -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function main
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Test class for the SHA256 class. Inherits the TestCase class from unittest | ||
| """ | ||
|
|
||
| def test_match_hashes(self) -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function test_match_hashes
| self.assertEqual(SHA256(msg).hash, hashlib.sha256(msg).hexdigest()) | ||
|
|
||
|
|
||
| def main() -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function main
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Test class for the SHA256 class. Inherits the TestCase class from unittest | ||
| """ | ||
|
|
||
| def test_match_hashes(self) -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function test_match_hashes
| self.assertEqual(SHA256(msg).hash, hashlib.sha256(msg).hexdigest()) | ||
|
|
||
|
|
||
| def main() -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function main
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
hashes/sha256.py
Outdated
| self.final_hash() | ||
|
|
||
| @staticmethod | ||
| def preprocessing(data) -> bytes: |
Please provide type hint for the parameter: data
| Test class for the SHA256 class. Inherits the TestCase class from unittest | ||
| """ | ||
|
|
||
| def test_match_hashes(self) -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function test_match_hashes
| self.assertEqual(SHA256(msg).hash, hashlib.sha256(msg).hexdigest()) | ||
|
|
||
|
|
||
| def main() -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function main
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Test class for the SHA256 class. Inherits the TestCase class from unittest | ||
| """ | ||
|
|
||
| def test_match_hashes(self) -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function test_match_hashes
| self.assertEqual(SHA256(msg).hash, hashlib.sha256(msg).hexdigest()) | ||
|
|
||
|
|
||
| def main() -> None: |
As there is no test file in this pull request nor any test function or class in the file hashes/sha256.py, please provide doctest for the function main
Awesome!
Describe your change:
Implementation of SHA-256 using pure Python. Have used the Black Formatter.
References
https://qvault.io/cryptography/how-sha-2-works-step-by-step-sha-256/ (in detail)
https://en.wikipedia.org/wiki/SHA-2 (Pseudocode)
Checklist:
Fixes: #{$ISSUE_NO}.The text was updated successfully, but these errors were encountered: