Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added solution for Project Euler problem 145 #5173

Merged
merged 8 commits into from Nov 10, 2021
Merged

Added solution for Project Euler problem 145 #5173

merged 8 commits into from Nov 10, 2021

Conversation

@chakeson
Copy link
Contributor

@chakeson chakeson commented Oct 9, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@chakeson
Copy link
Contributor Author

@chakeson chakeson commented Oct 20, 2021

Fixed all the tests that failed, can you run the workflows again?

@poyea
Copy link
Member

@poyea poyea commented Oct 21, 2021

Please see and wait for #5496.

@chakeson
Copy link
Contributor Author

@chakeson chakeson commented Oct 25, 2021

@poyea can you rerun workflows, since euler tests seem to be fixed.

poyea
poyea reviewed Oct 26, 2021
View changes
project_euler/problem_145/sol1.py Outdated Show resolved Hide resolved
chakeson and others added 3 commits Oct 26, 2021
@chakeson @poyea
nr -> number
8c21139 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@chakeson
nr -> number
d407d55
@poyea
Update sol1.py
59f7001
poyea
poyea approved these changes Nov 10, 2021
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩

@poyea poyea merged commit d6a1623 into TheAlgorithms:master Nov 10, 2021
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

@dhruvmanila dhruvmanila

@Kush1101 Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@chakeson @poyea