Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README files 1/7 #5754

Merged
merged 5 commits into from Nov 4, 2021
Merged

Add README files 1/7 #5754

merged 5 commits into from Nov 4, 2021

Conversation

@Leoriem-code
Copy link
Contributor

@Leoriem-code Leoriem-code commented Nov 2, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Leoriem-code Leoriem-code changed the title Uncomment code that has been commented due to slow execution affecting Travis (#5745) Adde README files 1/7 Nov 2, 2021
@Leoriem-code Leoriem-code mentioned this pull request Nov 2, 2021
Closed
14 tasks
poyea
poyea reviewed Nov 3, 2021
View changes
arithmetic_analysis/README.md Outdated
@@ -0,0 +1,7 @@
# Arithmetic analysis

It's a branch of mathematics that deal with solving linear equations.
Copy link
Member

@poyea poyea Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It's a branch of mathematics that deal with solving linear equations.
Arithmetic analysis is a branch of mathematics that deals with solving linear equations.

Or should we call it numerical analysis?

Copy link
Contributor Author

@Leoriem-code Leoriem-code Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you talk about it, I believe numerical analysis is better:

Examples of numerical analysis include: ordinary differential equations as found in celestial mechanics, numerical linear algebra in data analysis, and stochastic differential equations and Markov chains for simulating living cells in medicine and biology.

Copy link
Contributor Author

@Leoriem-code Leoriem-code Nov 3, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then, we would have to change the name of the folder too...

@Leoriem-code Leoriem-code changed the title Adde README files 1/7 Add README files 1/7 Nov 3, 2021
@Leoriem-code Leoriem-code requested a review from poyea Nov 3, 2021
poyea
poyea reviewed Nov 3, 2021
View changes
audio_filters/README.md Outdated Show resolved Hide resolved
poyea
poyea reviewed Nov 3, 2021
View changes
backtracking/README.md Outdated Show resolved Hide resolved
poyea
poyea reviewed Nov 3, 2021
View changes
bit_manipulation/README.md Outdated Show resolved Hide resolved
Leoriem-code and others added 3 commits Nov 3, 2021
@Leoriem-code @poyea
Update audio_filters/README.md
ccc19d6 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@Leoriem-code @poyea
Update backtracking/README.md
31d5d56 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@Leoriem-code @poyea
Update bit_manipulation/README.md
3407241 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@Leoriem-code Leoriem-code requested a review from poyea Nov 3, 2021
poyea
poyea approved these changes Nov 4, 2021
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩

@poyea poyea merged commit 47dd31f into TheAlgorithms:master Nov 4, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@Leoriem-code @poyea