Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add README files 2/8 #5766

Merged
merged 9 commits into from Nov 11, 2021
Merged

add README files 2/8 #5766

merged 9 commits into from Nov 11, 2021

Conversation

Leoriem-code
Copy link
Contributor

@Leoriem-code Leoriem-code commented Nov 4, 2021

Describe your change:

2nd of the 8 commit I make to add all README.md files

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews documentation tests are failing labels Nov 4, 2021
@algorithms-keeper algorithms-keeper bot removed the tests are failing label Nov 4, 2021
@Leoriem-code Leoriem-code mentioned this pull request Nov 4, 2021
Closed
poyea
poyea reviewed Nov 7, 2021
View changes
cellular_automata/README.md Outdated Show resolved Hide resolved
poyea
poyea reviewed Nov 7, 2021
View changes
ciphers/README.md Outdated Show resolved Hide resolved
poyea
poyea reviewed Nov 7, 2021
View changes
compression/README.md Outdated
# Compression

Data compression is everywhere, you need it to store data without taking too much space.
Either the compression lose some data (such as images in .jpg) or it is lossless (.png).
Copy link
Member

@poyea poyea Nov 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lossy?

Copy link
Contributor Author

@Leoriem-code Leoriem-code Nov 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poyea Would

Either the compression lose some data (then we talk about lossy compression, such as .jpg) or it do not (and then it is lossless compression, such as .png)

be better ?

Copy link
Member

@poyea poyea Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

poyea
poyea reviewed Nov 7, 2021
View changes
computer_vision/README.md Outdated Show resolved Hide resolved
poyea
poyea reviewed Nov 7, 2021
View changes
conversions/README.md Outdated Show resolved Hide resolved
Leoriem-code and others added 3 commits Nov 7, 2021
@Leoriem-code @poyea
Update ciphers/README.md
8533b8e 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@Leoriem-code @poyea
Update conversions/README.md
dcc9e8d 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@Leoriem-code @poyea
Update cellular_automata/README.md
39ddc48 
Co-authored-by: John Law <johnlaw.po@gmail.com>
poyea
poyea reviewed Nov 10, 2021
View changes
compression/README.md Outdated
# Compression

Data compression is everywhere, you need it to store data without taking too much space.
Either the compression lose some data (such as images in .jpg) or it is lossless (.png).
Copy link
Member

@poyea poyea Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

computer_vision/README.md Outdated Show resolved Hide resolved
conversions/README.md Outdated Show resolved Hide resolved
@Leoriem-code Leoriem-code requested a review from poyea Nov 10, 2021
poyea
poyea approved these changes Nov 11, 2021
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews label Nov 11, 2021
@poyea poyea merged commit 6314195 into TheAlgorithms:master Nov 11, 2021
2 checks passed
@Leoriem-code Leoriem-code deleted the add-README-files branch Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Leoriem-code @poyea