Skip to content

feat: Add basic issue forms #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: Add basic issue forms #5822

wants to merge 1 commit into from

Conversation

Panquesito7
Copy link
Member

Describe your change:

  • Add basic issue forms.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 12, 2021
@stale
Copy link

stale bot commented Apr 29, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Apr 29, 2022
@Panquesito7 Panquesito7 removed the stale Used to mark an issue or pull request stale. label Apr 29, 2022
@Panquesito7
Copy link
Member Author

Panquesito7 commented Apr 29, 2022 •
edited
Loading

@AnupKumarPanwar.

@stale
Copy link

stale bot commented Jun 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jun 13, 2022
@Panquesito7 Panquesito7 removed the stale Used to mark an issue or pull request stale. label Jun 13, 2022
@stale
Copy link

stale bot commented Jul 31, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jul 31, 2022
@Panquesito7 Panquesito7 removed the stale Used to mark an issue or pull request stale. label Aug 1, 2022
@dhruvmanila dhruvmanila self-assigned this Aug 3, 2022
dhruvmanila
dhruvmanila requested changes Aug 6, 2022
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts. Also, I don't see any point of having the other issue form.

.github/ISSUE_TEMPLATE/bug_report.yml
description: Create a bug report to help us address errors in the repository
title: "[BUG] <bug description>"
labels: [bug]
body:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more required information:

  • Repository commit
  • OS, Python version
  • Steps to reproduce (important!)

.github/ISSUE_TEMPLATE/bug_report.yml
@@ -0,0 +1,23 @@
name: Bug report
description: Create a bug report to help us address errors in the repository
title: "[BUG] <bug description>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "[BUG] <bug description>"
title: "<bug description>"

I would not prefer to have this as we already label the issue with bug. Also, instead of a text, this should be a placeholder.

.github/ISSUE_TEMPLATE/feature_request.yml
@@ -0,0 +1,38 @@
name: Feature request
description: Suggest features, propose improvements, discuss new ideas.
title: "[FEATURE]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion, not a big fan of prefixed title. We have labels for that.

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Aug 6, 2022
@Panquesito7
Copy link
Member Author

I don't see any point of having the other issue form

That's so people cannot make blank issues without any content. They have to provide some content if none of the provided issue templates fits their problem. Without this, people won't be able to make any other miscellaneous issues if we disable blank issues. Hope you understand. 🙂

@dhruvmanila dhruvmanila mentioned this pull request Oct 2, 2022
Merged
15 tasks
@dhruvmanila
Copy link
Member

closing in favor of #6533

@dhruvmanila dhruvmanila closed this Oct 2, 2022
@cclauss cclauss deleted the add_issue_templates branch October 2, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gptkrsh gptkrsh gptkrsh approved these changes

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

@dhruvmanila dhruvmanila

Labels
awaiting changes A maintainer has requested changes to this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panquesito7 @dhruvmanila @gptkrsh