Skip to content

Added to maths/numerical_integration.py #5862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Added to maths/numerical_integration.py #5862

wants to merge 5 commits into from

Conversation

NoahSchiro
Copy link

@NoahSchiro NoahSchiro commented Dec 1, 2021 •
edited
Loading

Describe your change:

I added all of the typical methods of numerical integration instead of just the trapezoidal algorithm. The file now includes right endpoint, left endpoint, midpoint, Simpson's rule, and trapezoidal integration.

I would recommend to the writers that the following files (in the maths directory) be deleted for the sake of eliminating redundancy:
area_under_curve.py
simpsons_rule.py
trapezoidal_rule.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@NoahSchiro NoahSchiro requested a review from Kush1101 as a code owner December 1, 2021 23:24
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Dec 1, 2021
@stale
Copy link

stale bot commented Apr 19, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Apr 19, 2022
@stale stale bot removed the stale Used to mark an issue or pull request stale. label May 25, 2022
@ghost ghost added the tests are failing Do not merge until tests pass label May 25, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jul 10, 2022
@cclauss
Copy link
Member

cclauss commented Oct 1, 2022

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that do not have passing tests.

@cclauss cclauss closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files stale Used to mark an issue or pull request stale. tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoahSchiro @cclauss @poyea