added recursive linear search #5885
Conversation
added the recursive implementation of the linear search. Which accepts the array and target as input and returns the index of target in the array.
ghost
added
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
searches/recursive_linear_search.py
Outdated
| python3 recursive_linear_search.py | ||
|
|
||
| """ | ||
| def recursive_linear_search(array:list,target:int,index=0)-> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/recursive_linear_search.py, please provide doctest for the function recursive_linear_search
Please provide type hint for the parameter: index
ghost
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| python3 recursive_linear_search.py | ||
|
|
||
| """ | ||
| def recursive_linear_search(array:list,target:int,index:int =0)-> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/recursive_linear_search.py, please provide doctest for the function recursive_linear_search
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please make sure the code passes pre-commit checks. |
|
In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that do not have passing tests. |
added the recursive implementation of the linear search. Which accepts the array and target as input and returns the index of the target in the array.
Describe your change:
added recursive linear search to the search directory. It is a recursive implementation of the linear search algorithm.
it takes 2 inputs array and target and returns the index of the target in the given array else return -1 if the element is not found in the array.
Checklist:
Fixes: #{$ISSUE_NO}.