Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate is_prime related functions #5892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove duplicate is_prime related functions #5892

wants to merge 1 commit into from
+9 −9

Conversation

@paulosgf
Copy link

@paulosgf paulosgf commented Dec 29, 2021 •
edited

Fixes (#5434)

  • Update ciphers.rabin_miller.py
    maths.miller_rabin.py

Describe your change:

Remove duplicate is_prime related functions

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@paulosgf
Fixes (TheAlgorithms#5434)
eacca6b 
* Update ciphers.rabin_miller.py
         maths.miller_rabin.py
@paulosgf paulosgf requested a review from Kush1101 as a code owner Dec 29, 2021
@paulosgf
Copy link
Author

@paulosgf paulosgf commented Jan 5, 2022

Hi @Kush1101!
Can you verify my PR, please!

@paulosgf paulosgf mentioned this pull request Jan 5, 2022
Open
@paulosgf paulosgf changed the title Fixes (#5434) Remove duplicate is_prime related functions Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kush1101 Kush1101

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
1 participant
@paulosgf