Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken OMG link #30383

Merged
merged 1 commit into from Feb 14, 2022
Merged

Fix broken OMG link #30383

merged 1 commit into from Feb 14, 2022

Conversation

davidgilbertson
Copy link
Contributor

@davidgilbertson davidgilbertson commented Jan 4, 2022

I got the new link from this page: https://www.omg.org/spec/PYTH

I'm not certain that it's the right doc, but the dates and title match.

hugovk
hugovk approved these changes Jan 7, 2022
Copy link
Member

@hugovk hugovk left a comment

👍

The old link does work for me (macOS/Chrome) and it downloads this file:

formal-02-11-05.pdf

But if it's not working for others, then it should be replaced. It's also http not https.

Here's the document at the new link, an added benefit is it opens in the browser rather than downloading to disk.

I can confirm they're identical binary files:

formal-02-11-05.pdf

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 7, 2022
Copy link
Sponsor Member

@Mariatta Mariatta left a comment

Thanks. The old url works for me, though it downloads the file, whereas the new link opens in the browser. I think opening the file in the browser is better.

@Mariatta Mariatta merged commit 04215a4 into python:main Feb 14, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Feb 14, 2022

Thanks @davidgilbertson for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2022
(cherry picked from commit 04215a4)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 14, 2022

GH-31342 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2022
(cherry picked from commit 04215a4)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 14, 2022

GH-31343 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Feb 14, 2022
(cherry picked from commit 04215a4)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
Mariatta pushed a commit that referenced this pull request Feb 15, 2022
(cherry picked from commit 04215a4)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
(cherry picked from commit 04215a4)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants