Skip to content

bpo-46299: Improve test_descr #30475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2022
Merged

bpo-46299: Improve test_descr #30475

merged 1 commit into from
Jan 8, 2022

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jan 8, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jan 8, 2022
@corona10 corona10 changed the title bpo-46299 Improve test_descr bpo-46299: Improve test_descr Jan 8, 2022
@corona10
Copy link
Member Author

corona10 commented Jan 8, 2022 •
edited
Loading

@sobolevn

  • Update to assertRaises if msg itself is not important.
  • Not to handle switching stdout directly from the user side to avoid mistakes.
  • Will not backport this PR since this PR is just an improvment.

Do you want to take a look?

sobolevn
sobolevn approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@corona10 corona10 merged commit 45d44b9 into python:main Jan 8, 2022
@corona10 corona10 deleted the bpo-46299 branch January 8, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @sobolevn @the-knights-who-say-ni @bedevere-bot