Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46249: Move set lastrowid out of the sqlite3 query loop #30489

Merged
merged 1 commit into from Jan 22, 2022
Merged

bpo-46249: Move set lastrowid out of the sqlite3 query loop #30489

merged 1 commit into from Jan 22, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 8, 2022 •
edited by bedevere-bot

@erlend-aasland erlend-aasland requested a review from malemburg Jan 8, 2022
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 8, 2022

(GitHub would not let me resurrect GH-30371 because I deleted the original branch.)

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 8, 2022

Skipping news as it is an internal change only. No user visible effects.

@erlend-aasland erlend-aasland changed the title bpo-46249: Move set lastrowid out of the sqlite3 query loop bpo-46249: Move set lastrowid out of the sqlite3 query loop Jan 8, 2022
@erlend-aasland erlend-aasland changed the title bpo-46249: Move set lastrowid out of the sqlite3 query loop bpo-46249: Move set lastrowid out of the sqlite3 query loop Jan 8, 2022
@erlend-aasland erlend-aasland requested a review from pablogsal Jan 8, 2022
@felixxm
Copy link
Contributor

felixxm commented Jan 12, 2022

I confirmed this doesn't break anything in Django tests ✔️

@erlend-aasland erlend-aasland requested a review from corona10 Jan 20, 2022
corona10
corona10 approved these changes Jan 22, 2022
View changes
Copy link
Member

@corona10 corona10 left a comment

I've looked closely at the change, but it doesn't seem like a regression will happen.
LGTM

@corona10 corona10 merged commit 38afeb1 into python:main Jan 22, 2022
11 checks passed
@erlend-aasland erlend-aasland deleted the sqlite-optimise-query-loop/last-row-id branch Jan 22, 2022
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 22, 2022

Thanks for reviewing, Dong-hee!

@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@berkerpeksag berkerpeksag

@malemburg malemburg

@pablogsal pablogsal

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erlend-aasland @felixxm @corona10 @the-knights-who-say-ni @bedevere-bot