Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46272: Fix two heading comments in python.gram #30499

Merged
merged 1 commit into from Jan 9, 2022
Merged

bpo-46272: Fix two heading comments in python.gram #30499

merged 1 commit into from Jan 9, 2022

Conversation

@mdickinson
Copy link
Member

@mdickinson mdickinson commented Jan 9, 2022 •
edited by miss-islington

One typo fix and one heading change, both in comments. No functional changes.

https://bugs.python.org/issue46272

Automerge-Triggered-By: GH:pablogsal
pablogsal
pablogsal approved these changes Jan 9, 2022
View changes
Copy link
Member

@pablogsal pablogsal left a comment

Thanks @mdickinson !

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 9, 2022

I'm backporting since the comments appear in the grammar docs.

@miss-islington miss-islington merged commit 1bee9a4 into python:main Jan 9, 2022
11 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 9, 2022

Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 9, 2022

Sorry, @mdickinson, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1bee9a4625e101d3308831de37590f4e2f57c71c 3.10

@miss-islington miss-islington self-assigned this Jan 9, 2022
@mdickinson
Copy link
Member Author

@mdickinson mdickinson commented Jan 9, 2022 •
edited

@pablogsal said:

I'm backporting since the comments appear in the grammar docs.

But @miss-islington said:

Sorry, @mdickinson, I could not cleanly backport this to 3.10 due to a conflict.

Looks like the 3.10 version of the file doesn't have the section headings (GH-27502 wasn't backported), so there's nothing to do here.

@mdickinson mdickinson deleted the fix-grammar-headings branch Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@lysnikolaou lysnikolaou

Assignees

@miss-islington miss-islington

Labels
CLA signed needs backport to 3.10 🤖 automerge skip news
Projects
None yet
Milestone
No milestone
5 participants
@mdickinson @pablogsal @miss-islington @the-knights-who-say-ni @bedevere-bot