Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add ASV benchmark link to README #21956

Merged
merged 1 commit into from Dec 13, 2021
Merged

Conversation

@ojeda-e
Copy link
Contributor

@ojeda-e ojeda-e commented Dec 11, 2021

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR fixes #21898

Changes include:

  • Benchmark badge added to README. (suggested by @ogrisel)

Any other comments?

I am not sure where to add the link to benchmarks on the home page. Didn't find an optimal place. I'm pinging @lorentzenchr since he opened the issue, maybe I can have their suggestion? :) Or maybe in the community section?

I also noticed the link is in the contributing page and it includes a nice explanation. Maybe the badge on the README will suffice?
Happy to help and modify accordingly.

Thanks!

Copy link
Member

@ogrisel ogrisel left a comment

LGTM. Here is how it renders:

image

Copy link
Member

@lorentzenchr lorentzenchr left a comment

LGTM
@ojeda-e Thanks for this PR.

@lorentzenchr lorentzenchr changed the title DOC: Added ASV benchmark link DOC Add ASV benchmark link to README Dec 13, 2021
@lorentzenchr lorentzenchr merged commit b001e62 into scikit-learn:main Dec 13, 2021
34 checks passed
glemaitre added a commit to glemaitre/scikit-learn that referenced this issue Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants