Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Use conda-forge's openmp in osx to build wheels #22109

Merged
merged 2 commits into from Jan 3, 2022
Merged

CI Use conda-forge's openmp in osx to build wheels #22109

merged 2 commits into from Jan 3, 2022

Conversation

@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Jan 1, 2022

Reference Issues/PRs

Alternative #22105

What does this implement/fix? Explain your changes.

Uses libomp from conda-forge
@thomasjpfan thomasjpfan changed the title CI Use conda for openmp for osx [cd build] CI Use conda-forge for openmp for osx Jan 1, 2022
@thomasjpfan thomasjpfan changed the title CI Use conda-forge for openmp for osx CI Use conda-forge to get openmp in osx Jan 1, 2022
@thomasjpfan thomasjpfan changed the title CI Use conda-forge to get openmp in osx CI Use conda-forge to get openmp in osx to build wheels Jan 1, 2022
@thomasjpfan thomasjpfan changed the title CI Use conda-forge to get openmp in osx to build wheels CI Use conda-forge's openmp in osx to build wheels Jan 1, 2022
@thomasjpfan thomasjpfan changed the title CI Use conda-forge's openmp in osx to build wheels [NO MERGE] CI Use conda-forge's openmp in osx to build wheels Jan 1, 2022
@thomasjpfan thomasjpfan marked this pull request as ready for review Jan 1, 2022
@thomasjpfan thomasjpfan changed the title [NO MERGE] CI Use conda-forge's openmp in osx to build wheels CI Use conda-forge's openmp in osx to build wheels Jan 1, 2022
@thomasjpfan thomasjpfan mentioned this pull request Jan 1, 2022
Closed
@thomasjpfan
Copy link
Member Author

@thomasjpfan thomasjpfan commented Jan 1, 2022

The timeouts on i686 on linux is unrelated to the fixes for osx

ogrisel
ogrisel approved these changes Jan 2, 2022
View changes
Copy link
Member

@ogrisel ogrisel left a comment

LGTM as a stop gap solution.

jeremiedbb
jeremiedbb approved these changes Jan 3, 2022
View changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

LGTM as a temporary workaround. Thanks @thomasjpfan !

At some point we'll need to dig into libomp to understand what's going wrong in versions > 11

@jeremiedbb jeremiedbb merged commit 42a34e8 into scikit-learn:main Jan 3, 2022
56 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel

@jeremiedbb jeremiedbb

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasjpfan @ogrisel @jeremiedbb